[AutoPR azure-resourcemanager-containerservicepreparedimgspec]-generated-from-SDK Generation - Java-6569812#49681
Conversation
|
namespace review not completed Azure/azure-sdk#10095 |
|
service-dir in your tspconfig for java should be containerservice |
3564dc0 to
7a99d57
Compare
|
Running a new codegen with HEAD of Azure/azure-rest-api-specs#44338 into this branch, will re-open after that. (I had to revert the whole thing because of the wrong service dir) |
tsp-location points on PR, not main
|
OK. CI green. We will need to wait for the completion of the namespace review PR, and do one more regen from specs main branch (after your specs PR merge). If the namespace changes again, we will need to do one more reset on this branch (or maybe just use a new PR). |
|
Makes sense- does that mean I'm just waiting for namespace approval on Azure/azure-sdk#10095 at the moment? Or do I need to get the specs PR merged before the issue linked above? |
|
You probably first wait for namespace approved. Then update the specs PR with the approved namespace / package name (before approval they are not final). Then merge and we can regen here. |
|
Java package name seems changed again. You can generate a new PR (this is faster for me -- that I don't need to again reset on this), or we can still work on this PR |
|
I'm happy to just open a new PR if that's easier for you, namepace approval and package name changes are now done so hopefully no more issues |
27e43a2 to
53e4322
Compare
…osoft.ContainerService/preparedimagespecification/tspconfig.yaml', and CommitSHA: '6febc0e86632c12f81e22bd07e604d480b38481e' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6569925 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
|
Azure Pipelines: Successfully started running 1 pipeline(s). 35 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
weidongxu-microsoft
left a comment
There was a problem hiding this comment.
Regenerated from specs main (commit 6febc0e) after resetting the branch. Now a single approved module azure-resourcemanager-containerservicepreparedimgspec (namespace review Azure/azure-sdk#10095 completed). The stale hyphenated containerservice-preparedimgspec module is removed. Version 1.0.0-beta.1, api-version 2026-02-02-preview (beta, consistent). No incorrect LRO header/response models. LGTM.
|
namespace review completed Azure/azure-sdk#10095 |
|
/azp run prepare-pipelines |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
I've merged the PR |
Configurations: 'specification/containerservice/resource-manager/Microsoft.ContainerService/preparedimagespecification/tspconfig.yaml', SDK Release Type: beta, and CommitSHA: '6febc0e86632c12f81e22bd07e604d480b38481e' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6569812 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=35135 Submitted by: abdulasfari@microsoft.com
Release Plan Details