Skip to content

[AutoPR azure-resourcemanager-containerservicepreparedimgspec]-generated-from-SDK Generation - Java-6569812#49681

Merged
weidongxu-microsoft merged 1 commit into
mainfrom
sdkauto/azure-resourcemanager-containerservice-preparedimgspec-6501619
Jul 16, 2026
Merged

[AutoPR azure-resourcemanager-containerservicepreparedimgspec]-generated-from-SDK Generation - Java-6569812#49681
weidongxu-microsoft merged 1 commit into
mainfrom
sdkauto/azure-resourcemanager-containerservice-preparedimgspec-6501619

Conversation

@azure-sdk-automation

@azure-sdk-automation azure-sdk-automation Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Copilot AI review requested due to automatic review settings June 30, 2026 17:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot can't review bot-authored pull requests automatically. A user with Copilot access can request a review manually.

@github-actions github-actions Bot added the Mgmt This issue is related to a management-plane library. label Jun 30, 2026
@weidongxu-microsoft

Copy link
Copy Markdown
Member

namespace review not completed Azure/azure-sdk#10095

@weidongxu-microsoft

Copy link
Copy Markdown
Member

service-dir in your tspconfig for java should be containerservice

@weidongxu-microsoft
weidongxu-microsoft force-pushed the sdkauto/azure-resourcemanager-containerservice-preparedimgspec-6501619 branch from 3564dc0 to 7a99d57 Compare July 1, 2026 03:05
@weidongxu-microsoft

weidongxu-microsoft commented Jul 1, 2026

Copy link
Copy Markdown
Member

Running a new codegen with HEAD of Azure/azure-rest-api-specs#44338 into this branch, will re-open after that. (I had to revert the whole thing because of the wrong service dir)

@azure-sdk-automation azure-sdk-automation Bot changed the title [AutoPR azure-resourcemanager-containerservice-preparedimgspec]-generated-from-SDK Generation - Java-6501619 [AutoPR azure-resourcemanager-containerservice-preparedimgspec]-generated-from-SDK Generation - Java-6504708 Jul 1, 2026
@weidongxu-microsoft
weidongxu-microsoft self-requested a review July 1, 2026 04:02
@weidongxu-microsoft
weidongxu-microsoft dismissed their stale review July 1, 2026 04:02

tsp-location points on PR, not main

@weidongxu-microsoft

weidongxu-microsoft commented Jul 1, 2026

Copy link
Copy Markdown
Member

OK. CI green.

We will need to wait for the completion of the namespace review PR, and do one more regen from specs main branch (after your specs PR merge).

If the namespace changes again, we will need to do one more reset on this branch (or maybe just use a new PR).

@aboodasfari

Copy link
Copy Markdown
Member

Makes sense- does that mean I'm just waiting for namespace approval on Azure/azure-sdk#10095 at the moment?

Or do I need to get the specs PR merged before the issue linked above?

@weidongxu-microsoft

weidongxu-microsoft commented Jul 1, 2026

Copy link
Copy Markdown
Member

You probably first wait for namespace approved. Then update the specs PR with the approved namespace / package name (before approval they are not final). Then merge and we can regen here.

@weidongxu-microsoft

Copy link
Copy Markdown
Member

Java package name seems changed again.

You can generate a new PR (this is faster for me -- that I don't need to again reset on this), or we can still work on this PR

@weidongxu-microsoft
weidongxu-microsoft self-requested a review July 16, 2026 03:02
@azure-sdk-automation azure-sdk-automation Bot changed the title [AutoPR azure-resourcemanager-containerservice-preparedimgspec]-generated-from-SDK Generation - Java-6504708 [AutoPR azure-resourcemanager-containerservicepreparedimgspec]-generated-from-SDK Generation - Java-6569812 Jul 16, 2026
@azure-sdk-automation azure-sdk-automation Bot added the auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. label Jul 16, 2026
@aboodasfari

Copy link
Copy Markdown
Member

I'm happy to just open a new PR if that's easier for you, namepace approval and package name changes are now done so hopefully no more issues

@weidongxu-microsoft
weidongxu-microsoft force-pushed the sdkauto/azure-resourcemanager-containerservice-preparedimgspec-6501619 branch from 27e43a2 to 53e4322 Compare July 16, 2026 04:57
…osoft.ContainerService/preparedimagespecification/tspconfig.yaml', and CommitSHA: '6febc0e86632c12f81e22bd07e604d480b38481e' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6569925 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
35 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@weidongxu-microsoft weidongxu-microsoft left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regenerated from specs main (commit 6febc0e) after resetting the branch. Now a single approved module azure-resourcemanager-containerservicepreparedimgspec (namespace review Azure/azure-sdk#10095 completed). The stale hyphenated containerservice-preparedimgspec module is removed. Version 1.0.0-beta.1, api-version 2026-02-02-preview (beta, consistent). No incorrect LRO header/response models. LGTM.

@weidongxu-microsoft

Copy link
Copy Markdown
Member

namespace review completed Azure/azure-sdk#10095

@weidongxu-microsoft

Copy link
Copy Markdown
Member

/azp run prepare-pipelines

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@weidongxu-microsoft
weidongxu-microsoft merged commit b760285 into main Jul 16, 2026
25 checks passed
@weidongxu-microsoft
weidongxu-microsoft deleted the sdkauto/azure-resourcemanager-containerservice-preparedimgspec-6501619 branch July 16, 2026 05:29
@weidongxu-microsoft

Copy link
Copy Markdown
Member

I've merged the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants